Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove stale values from docker-compose.yml #1822

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

bo0tzz
Copy link
Member

@bo0tzz bo0tzz commented Feb 21, 2023

No description provided.

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
immich ⬜️ Ignored (Inspect) Feb 21, 2023 at 8:42PM (UTC)

@@ -40,10 +40,6 @@ services:
- model-cache:/cache
env_file:
- .env
environment:
- NODE_ENV=production
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need this one to toggle hot-reload in development

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This container doesn't use node anymore ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still use that environment variable name 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha

@alextran1502 alextran1502 merged commit 24d672a into main Feb 21, 2023
@alextran1502 alextran1502 deleted the chore/compose-cleanup branch February 21, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants