feat(web): theme/locale preferences and improve SSR #1832
Merged
+146
−154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new PR from #1814, because that one had a bit of a snowball effect.
svelte-local-storage-store
package for persisting preferences to localStorageSuddenly SSR started actually working. Previously any server-side rendered page would have an empty
<main></main>
element so it wasn't doing much. Having SSR for pages means we can't usedocument
,navigator
,window
, etc and a couple of issues popped up because of that:navigator.language
, so moved locale to preferences store$app/environment
so a manual mock has been addedonDestroy
, because it also runs for SSR