fix(mobile): Removes deleted asset from gallery pages #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -31,7 +31,7 @@ import 'package:openapi/api.dart' as api; | |||
|
|
|||
| // ignore: must_be_immutable | |||
| class GalleryViewerPage extends HookConsumerWidget { | |||
| late List<Asset> assetList; | |||
There was a problem hiding this comment.
Why changing late to final would fix the issue?
There was a problem hiding this comment.
This has no effect here. It doesn't fix the issue, it just should not have been assigned late as there is no case it is allowed to be null. Unless I'm massively misunderstanding something here...
late tells the compiler that while this variable is not guarenteed to be non-null at initialization, it will be initialized later (hence, late) to something non-null. It's dangerous and usually unnecessary. In this case, this is just final. The fix was removing the asset from the list lower down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where deleting an image from the gallery view would advance the page view controller, but not remove it from the page view. That is, you could just page back to it and it would still be there.