feat(server): Add support for client-side hashing #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/client-side-hashing
…/client-side-hashing
…/client-side-hashing
…/client-side-hashing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Is it worth doing that in a separate PR, to keep review sizes down? |
jrasm91
reviewed
May 22, 2023
There was a problem hiding this comment.
I think the scope of this PR has changed a lot over time. It'd be good to update the description to match what's actually being changed here. From what I can tell it is:
- New server endpoint for checking for duplicates via checksum
- No changes to how mobile uploads work
- Removing unique check from web
- Updating checksum column to be non-nullable
If that is all that is changing, we should remove any unrelated changes, like changes to get the objects and locations for user.
server/libs/infra/src/migrations/1679662469076-RemoveChecksumIndex.ts
Outdated
Show resolved
Hide resolved
…/client-side-hashing
jrasm91
reviewed
May 23, 2023
jrasm91
approved these changes
May 23, 2023
etnoy
dismissed
michelheusschen’s stale review
The review has been handled but github still shows it as a requested change, I'm closing it
michelheusschen
approved these changes
May 24, 2023
alextran1502
changed the title
3 tasks
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first major PR related to client side hashing. Here, we focus on getting the server-side plumbing done.