Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): use current schema for search/explore #2331

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Apr 25, 2023

Previously, typesense would only uses fully-indexed collections. This changes that to always use the most recent collection, regardless of index status. The results of this change should be:

  1. Explore/search functionality is available sooner on new installs (searchable as they're being indexed)
  2. Migrations won't break search/explore with 400 Bad Request errors while indexing is happening (if explore references a new field, that doesn't exist in the old schema, it would lead to this situation)

Related to:

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
immich ⬜️ Ignored (Inspect) Apr 25, 2023 3:24pm

@alextran1502 alextran1502 merged commit aa91b94 into main Apr 25, 2023
18 checks passed
@alextran1502 alextran1502 deleted the fix/use-most-recent-schema branch April 25, 2023 17:21
alextran1502 added a commit that referenced this pull request Apr 25, 2023
* added services

* add boiler plate

* cropped face

* created person and link with asset

* fix(server): use current schema for search/explore (#2331)

* pr feedback

* pr feedback

* pr feedback

* pr feedback

* comment

* using crypto repo

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants