Clean code of shared folder #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xpwmaosldk
commented
Jun 23, 2022
xpwmaosldk
commented
- Change local variables type (ref: https://dart.dev/guides/language/effective-dart/design#dont-redundantly-type-annotate-initialized-local-variables)
- Move UploadProfileImage method from UserService to NetworkService
| child: ImmichLoadingIndicator(), | ||
| ), | ||
| ) | ||
| : const SizedBox(); |
There was a problem hiding this comment.
I am not used to return SizedBox for empty Widget, is it the same as return Container()?
There was a problem hiding this comment.
Yes, something different.
ref: https://dart-lang.github.io/linter/lints/sized_box_for_whitespace.html
There was a problem hiding this comment.
Learning a lot from you!
| late final Dio dio; | ||
|
|
||
| NetworkService() { | ||
| dio = Dio(); |
There was a problem hiding this comment.
This is very cool, to instantiate only once and add the interceptor at the constructor. Love this change!
|
This is good to merge, let me know if there is anything else you would like to add Edited - Forgot the question about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.