Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server,ml): remove object detection job and endpoint #2627

Merged
merged 2 commits into from Jun 1, 2023
Merged

chore(server,ml): remove object detection job and endpoint #2627

merged 2 commits into from Jun 1, 2023

Conversation

mertalev
Copy link
Contributor

Per the discussion in #2524, this PR removes the object detection model as it can be detrimental to tag quality, tagging will likely be done with image captioning in the future, and in the meantime image classification fulfills the same role.

@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) May 31, 2023 10:49pm

@alextran1502 alextran1502 merged commit 631f13c into immich-app:main Jun 1, 2023
18 checks passed
@mertalev mertalev deleted the chore/disable-object-detection branch June 1, 2023 03:00
alextran1502 pushed a commit that referenced this pull request Jun 3, 2023
* env variables for tags, faces and eager startup

* chore(server,ml): remove object detection job and endpoint (#2627)

* removed object detection job

* removed object detection endpoint

* env variables for tags, faces and eager startup

* download without caching models if not eager

* simplified `get_cached_model`

* re-added env for clip text model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants