Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Android): guard against missing EXIF info #2965

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Jun 26, 2023

Many asset backups on Android are corrupt because the app did not have permission to access media file location (GPS EXIF data). This results in checksum being different after this permission is granted leading to sync issues.

This PR adds checks to a) request the permissions and b) only backup files if permissions are granted

@fyfrey fyfrey requested a review from alextran1502 June 26, 2023 14:54
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
immich ⬜️ Ignored (Inspect) Jun 26, 2023 2:54pm

@alextran1502 alextran1502 merged commit 99f85fb into main Jun 26, 2023
18 checks passed
@alextran1502 alextran1502 deleted the dev/android-access-media-location branch June 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants