refactor(server): download assets #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jrasm91
force-pushed
the
refactor/download-assets
branch
from
918c767
to
7065635
Compare
jrasm91
commented
Jun 30, 2023
alextran1502
approved these changes
Jun 30, 2023
brighteyed
reviewed
Jun 30, 2023
Comment on lines
+99
to
+113
| const paths: Record<string, boolean> = {}; | ||
|
|
||
| for (const { originalPath, originalFileName } of assets) { | ||
| const ext = extname(originalPath); | ||
| let filename = `${originalFileName}${ext}`; | ||
| for (let i = 0; i < 10_000; i++) { | ||
| if (!paths[filename]) { | ||
| break; | ||
| } | ||
| filename = `${originalFileName}+${i + 1}${ext}`; | ||
| } | ||
|
|
||
| paths[filename] = true; | ||
| zip.addFile(originalPath, filename); | ||
| } |
There was a problem hiding this comment.
I am late with my review, but it seems if we change the type of the Record to Record<string, number> the code looks cleaner:
const paths: Record<string, number> = {};
for (const { originalPath, originalFileName } of assets) {
const ext = extname(originalPath);
const baseName = `${originalFileName}${ext}`;
let filename = baseName;
let index = paths[baseName];
if (index === undefined) {
index = 0;
} else {
index++;
filename = `${originalFileName}+${index}${ext}`;
}
paths[baseName] = index;
zip.addFile(originalPath, filename);
}
There was a problem hiding this comment.
It's a shame as Array.prototype.group would make this quite nice.
There was a problem hiding this comment.
Just because it was merged doesn't mean it can't be fixed anymore lol 😛
Do you have an example of how array.group would look? I've never used it before.
There was a problem hiding this comment.
group is still experimental, so I can implement the suggestion from @brighteyed instead.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested scenarios: