fix(server): h264 and hevc not respecting max bitrate #3052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
H.264 and HEVC ignore
-maxrate
unless-bufsize
is also specified. This PR adds-bufsize
to the command when constraining bitrate with these codecs. The common suggestion is to set-bufsize
to twice the max bitrate to allow budgeting more bandwidth for difficult frames. The max bitrate is then the max rolling average over any 2 second period.Fixes #3050
Testing
h264
and set the max bitrate to a positive number.