Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): auth e2e #3492

Merged
merged 4 commits into from
Aug 1, 2023
Merged

test(server): auth e2e #3492

merged 4 commits into from
Aug 1, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Aug 1, 2023 •
edited

In this PR:

  • Remove try/catch that throws an internal error exception for admin signup
  • Move e2e test from e2e/ to test/e2e/
  • Update setup.ts to use postgres connection url
  • Add auth.e2e-spec.ts
  • Update user.e2e-spec.ts and album.e2e-spec.ts to follow the pattern of:
    • describe for API methods
    • it for test scanerios
    • beforeAll for one time module setup
    • afterAll for one time teardown
    • beforeEach for database resetting before each test
  • Update test-utils to reset the database via DELETE instead of TRUNCATE.

@vercel
Copy link

vercel bot commented Aug 1, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Aug 1, 2023 3:10pm

@jrasm91 jrasm91 marked this pull request as ready for review August 1, 2023 15:21
@alextran1502 alextran1502 merged commit e53625b into main Aug 1, 2023
20 checks passed
@alextran1502 alextran1502 deleted the test/auth-e2e branch August 1, 2023 15:49
@etnoy
Copy link
Contributor

etnoy commented Aug 1, 2023

That was a quick merge! Will hopefully be able to look at this next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@jbaez jbaez Awaiting requested review from jbaez

@etnoy etnoy Awaiting requested review from etnoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @etnoy @alextran1502