Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): asset store #3528

Merged
merged 2 commits into from
Aug 3, 2023
Merged

refactor(web): asset store #3528

merged 2 commits into from
Aug 3, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Aug 3, 2023 •
edited

Simplify the interface between asset grid and asset store. Preparation for timelines everywhere.

In this PR:

  • Merge AssetGridState into AssetStore
  • Don't store viewport in the store, but use it in the init method
  • Move all bucket calls to inside the store
  • Set bucket query options during asset store creation and use them in both requests

Tested Scenarios:

  • View partner shared timeline
  • Click around in timeline, scroll up, down
  • Select, click, shift select

@vercel
Copy link

vercel bot commented Aug 3, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 0:29am

@jrasm91 jrasm91 marked this pull request as ready for review August 3, 2023 03:41
brighteyed
brighteyed approved these changes Aug 3, 2023
View reviewed changes
web/src/lib/stores/assets.store.ts Outdated Show resolved Hide resolved
@alextran1502 alextran1502 merged commit 5617b57 into main Aug 3, 2023
21 checks passed
@alextran1502 alextran1502 deleted the refactor/asset-store branch August 3, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brighteyed brighteyed brighteyed approved these changes

@alextran1502 alextran1502 Awaiting requested review from alextran1502

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @brighteyed @alextran1502