refactor: time buckets (2) #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
alextran1502
reviewed
Aug 5, 2023
| } | ||
|
|
||
| return !!previousAsset; |
There was a problem hiding this comment.
Can you help explain the logic here?
There was a problem hiding this comment.
Just returns a boolean value to indicate if one was found or not. Makes it possible to fallback to navigating to the previous asset and again falling back to closing the viewer if there is not another asset to show.
Basically, when you archive an asset and it should advance, what if there is no next asset? Now we can know that and show the previous one instead. Double !! just converts it to a boolean.
alextran1502
approved these changes
Aug 5, 2023
|
Looks good to me, besides that one question, feel free to merge |
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to address auto navigating unarchived assets, etc.
In this PR:
Tested scenarios: