Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): use time buckets of person detail page (3) #3557

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Aug 5, 2023

In this PR:

  • Use time buckets on person detail page
  • Use time buckets on feature face selection page
  • Add an option to AssetGrid to allow for single selection (fires an on:select with the asset and doesn't show the multi-day/month selection options)
  • Move fullscreen modal + outclick to the SuggestionModel component and it maps that to the cancel event
  • Auto-scroll to top after a single selection (in AssetGrid)
  • Fix an issue where canceling the suggest merge modal would stop editing the name input
  • Add shift select to person detail view (Shift selection doesn't work in some views #3550)
  • View all assets for a person ([Feature] Facial Recognition Enhancements #2472)

Tested Scenarios:

  • Edit a name to a duplicate, click yes/no/close/out-click
  • Edit a name to a new name, saved
  • Select another feature photo, updated
  • Cancel feature photo selection, back to asset grid
  • Open merge modal via menu
  • Cancel merge modal
  • Confirm merge a person in merge modal

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2023 3:39am

@alextran1502 alextran1502 linked an issue Aug 5, 2023 that may be closed by this pull request
3 tasks
@alextran1502 alextran1502 merged commit ff32506 into main Aug 5, 2023
21 checks passed
@alextran1502 alextran1502 deleted the feat/time-buckets-3 branch August 5, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift selection doesn't work in some views
2 participants