Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/web): album description #3558

Merged
merged 10 commits into from
Aug 6, 2023
Merged

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Aug 5, 2023

In this PR:

  • Add an album description field (and associated migration)
  • Add it to the album response dto
  • Make it possible to set via create album / update album
  • Auto bump album schema version to prompt typesense re-indexing (to include the new field)

Tested scenarios

  • Create a new album still works :-)
  • e2e test successfully updates an album with a description
  • m: search with a term in the description brings back the album
  • Empty description displayed on the web
  • Edit description as the owner
  • None owner cannot modify description

@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2023 2:40am

@alextran1502 alextran1502 enabled auto-merge (squash) August 6, 2023 02:41
@alextran1502 alextran1502 changed the title feat(server): album description feat(server/web): album description Aug 6, 2023
@alextran1502 alextran1502 enabled auto-merge (squash) August 6, 2023 02:41
@alextran1502 alextran1502 merged commit 2f26a7e into main Aug 6, 2023
21 checks passed
@alextran1502 alextran1502 deleted the feat/album-description branch August 6, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants