Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): enable websocket #3765

Merged
merged 19 commits into from Oct 6, 2023
Merged

feat(web): enable websocket #3765

merged 19 commits into from Oct 6, 2023

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Aug 18, 2023

TODO

  • Add newly uploaded asset to new time bucket
  • Debouncing
  • Album page
  • Photo page
  • Remove message about refreshing page

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:41pm

web/src/lib/stores/assets.store.ts Outdated Show resolved Hide resolved
web/src/lib/stores/assets.store.ts Outdated Show resolved Hide resolved
@jrasm91
Copy link
Contributor

jrasm91 commented Sep 1, 2023

This is actually a bit tricky, because, even though we listen for the event, we should skip it if it doesn't belong to the current view. So, a new upload should not be added to the timeline if you are on the archive page.

@jrasm91 jrasm91 enabled auto-merge (squash) October 6, 2023 20:42
@alextran1502 alextran1502 merged commit 36b2194 into main Oct 6, 2023
21 checks passed
@alextran1502 alextran1502 deleted the feat/web-websocket branch October 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants