Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): full backend end-to-end testing with microservices #4225

Merged
merged 57 commits into from Oct 6, 2023
Merged

test(server): full backend end-to-end testing with microservices #4225

merged 57 commits into from Oct 6, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Sep 25, 2023 •
edited by etnoy

Mock the job repo in e2e test and add an option to call the implementation immediately.

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:53pm

@etnoy
Copy link
Contributor

etnoy commented Sep 26, 2023 •
edited

Note that the e2e tests require a recent version of node 21 nightly in order not to segfault.

EDIT: This is solved with the release of Node 20.8

@etnoy etnoy marked this pull request as ready for review September 26, 2023 11:54
@etnoy etnoy mentioned this pull request Sep 27, 2023
Closed
@etnoy
Copy link
Contributor

etnoy commented Sep 29, 2023

Added some initial developer docs on how to do e2e testing

jrasm91
jrasm91 commented Sep 29, 2023
View reviewed changes
server/test/e2e/setup-docker.ts Outdated Show resolved Hide resolved
server/test/e2e/setup.ts Show resolved Hide resolved
server/test/e2e/setup.ts Show resolved Hide resolved
server/test/test-utils.ts Outdated Show resolved Hide resolved
@etnoy etnoy changed the title test(server): asset e2e with job option test(server): full backend end-to-end testing with microservices Oct 2, 2023
@alextran1502
Copy link
Contributor

Can we resolve the conflict and merge this PR?

@etnoy
Copy link
Contributor

etnoy commented Oct 6, 2023

Can we resolve the conflict and merge this PR?

Funny you should ask, was doing that right now, haha

@etnoy
Copy link
Contributor

etnoy commented Oct 6, 2023

Can we resolve the conflict and merge this PR?

Done!

@jrasm91
Copy link
Contributor Author

jrasm91 commented Oct 6, 2023

I haven't looked at this recently and didn't get a change too this week, but I think if it all passes it is good enough for now. I'll hopefully come back to it and make any needed changes in a future PR. Thanks @etnoy for finishing it!

@etnoy
Copy link
Contributor

etnoy commented Oct 6, 2023

I haven't looked at this recently and didn't get a change too this week, but I think if it all passes it is good enough for now. I'll hopefully come back to it and make any needed changes in a future PR. Thanks @etnoy for finishing it!

It's all good to go. I had a minor question about setting an any type, but it's of no consequence. If anything pops up we'll fix it.

Merging this allows us to develop new features with TDD. It's very easy to create sophisticated tests now

@etnoy etnoy merged commit 8d5bf93 into main Oct 6, 2023
21 checks passed
@etnoy etnoy deleted the feat/e2e-with-jobs branch October 6, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etnoy etnoy etnoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @etnoy @alextran1502