fix(server): library control doesn't apply to new library from the third row

[alextran1502]

Fixes #4327

Fixed the issue of the index value in the #for-each loop doesn't update when passing in the function call, leading to library's content from the third row cannot be modified

The solution is to use the local variable of the component that keeps track of the state of the selected library and the library's index, then use that information in the function call.

Cause: Unknown - Svelte's magic

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
immich	⬜️ Ignored (Inspect)	Visit Preview		Oct 3, 2023 5:59pm

[jrasm91]

I think we have had several issues like this, where we have a context menu inside of a for loop and it generally leads to some problems. Why can't we just have the Context Menu be defined at the bottom of the file? It isn't using anything scoped anymore. Also, why do we need to keep track of both the selected index and selected library? Can we only keep track of the selected library instead?

[alextran1502]

@jrasm91 This is the current drop-in replacement for the initial implementation of this editing menu. We have a plan to move this to a separate modal, which has all the modification options on a single view for better UX. So the fix will ensure everything is still working until I roll out the modal design

[jrasm91]

Sounds good.