-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): added toggle for Sharing button in the sidebar #4674
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Hello, what is the purpose of this change? |
I'm the only user of my instance so don't need the sharing feature, so thought a toggle would be useful to reduce clutter for those in a similar position :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Can you help fix the build error with |
We still show add to shared album and other actions throughout the app. It might make sense to handle it everywhere instead of hiding it only from the sidebar if sharing is not needed entirely. |
@shenlong-tanwen I think what he has make sense since this is probably user preference |
)" This reverts commit daad025.
Sharing should be enabled by default. This turns it off for everybody by default once |
A simple toggle (defaults to True) to hide the Sharing button in the sidebar, in the Sidebar settings.