Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): added toggle for Sharing button in the sidebar #4674

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

upsetdog
Copy link
Contributor

A simple toggle (defaults to True) to hide the Sharing button in the sidebar, in the Sidebar settings.

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2023 1:24am

@alextran1502
Copy link
Contributor

Hello, what is the purpose of this change?

@upsetdog
Copy link
Contributor Author

Hello, what is the purpose of this change?

I'm the only user of my instance so don't need the sharing feature, so thought a toggle would be useful to reduce clutter for those in a similar position :)

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alextran1502
Copy link
Contributor

Can you help fix the build error with npm run format:fix in the web directory?

@shenlong-tanwen
Copy link
Member

I'm the only user of my instance so don't need the sharing feature, so thought a toggle would be useful to reduce clutter for those in a similar position :)

We still show add to shared album and other actions throughout the app. It might make sense to handle it everywhere instead of hiding it only from the sidebar if sharing is not needed entirely.

@alextran1502
Copy link
Contributor

@shenlong-tanwen I think what he has make sense since this is probably user preference

@alextran1502 alextran1502 changed the title Added toggle for Sharing button in the sidebar feat(web): added toggle for Sharing button in the sidebar Oct 29, 2023
@alextran1502 alextran1502 enabled auto-merge (squash) October 29, 2023 01:27
@alextran1502 alextran1502 merged commit daad025 into immich-app:main Oct 29, 2023
20 checks passed
alextran1502 added a commit that referenced this pull request Oct 29, 2023
@waclaw66
Copy link
Contributor

waclaw66 commented Oct 29, 2023

Sharing should be enabled by default. This turns it off for everybody by default once sidebar-settings settings already exists.
It's not the same as People, they can be found within Explore if turned off, but Sharing is available only within the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants