Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): multiple improvements for people page (1) #4717

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

martabal
Copy link
Member

@martabal martabal commented Oct 30, 2023

Changes made in this PR

Since #4153 has grown considerably in size and complexity, I'm dividing it into multiple, more manageable PRs.

There will be (at least) 3 PRs:

  • This initial PR includes all the minor enhancements mentioned in feat(server, web): unmerge person's assets #4153.
  • The second one will introduce the ability to re-assign faces to either new or existing person.
  • The third one (which brings the most complexity) will add the un-assign feature

Screenshots

Explore page Merge face selector Person page
2023-10-03.17-35-32.mp4
2023-10-03.17-38-09.mp4
Screenshot from 2023-10-30 11-43-55-2

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 0:30am

@alextran1502
Copy link
Contributor

Hello Martin, do you mind including screenshots or video for this enhancement?

@martabal
Copy link
Member Author

martabal commented Oct 30, 2023

Hello Martin, do you mind including screenshots or video for this enhancement?

Done. I used the screenshots from #4153, UI has changed a bit (Explore page have smaller icons for smaller screens and I aligned the merge icon on the merge face selector modal)

@alextran1502 alextran1502 merged commit 9a60578 into main Oct 30, 2023
21 checks passed
@alextran1502 alextran1502 deleted the feat/improve-people branch October 30, 2023 19:40
rikifrank pushed a commit to shefing/immich that referenced this pull request Nov 6, 2023
* fix(web): multiple improvements for people page

* feat: better responsive icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants