Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): update password change description text to use user name #5105

Merged
merged 1 commit into from Nov 24, 2023

Conversation

shenlong-tanwen
Copy link
Member

Changes made in the PR:

  • Password change form description translation text still had the old {firstName} and {lastName} placeholders which are now renamed to {name}

@jrasm91
Copy link
Contributor

jrasm91 commented Nov 17, 2023

this was in the initial PR, but I think we need to make the change in localizely instead.

@shenlong-tanwen
Copy link
Member Author

this was in the initial PR, but I think we need to make the change in localizely instead.

en-US file to which new texts and edits are usually made is also not updated. Also, since this is the placeholder and not the actual text to be translated, I guess we can handle this directly?

@jrasm91
Copy link
Contributor

jrasm91 commented Nov 17, 2023

I guess my point is just that I think non-english files might be overwritten when new translations are pulled from the platform (except for english probably).

@alextran1502 alextran1502 merged commit f222e47 into main Nov 24, 2023
20 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-change-password-description branch November 24, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants