feat(web): Lazy load thumbnails on the people page #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
reviewed
Nov 28, 2023
Instead of loading all people thumbnails at once, only the first few should be loaded eagerly. This reduces the load on client and server side.
l0nax
force-pushed
the
lazy-load-people-thumbnails
branch
from
86f58e8
to
9613635
Compare
bo0tzz
approved these changes
Nov 28, 2023
jrasm91
approved these changes
Nov 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My browser freezes for a short amount of time when I open the people page (approx. 600+ non-hidden faces).
I managed to reproduce this behavior every time with
This PR ensures that the thumbnails are lazy loaded with the native
loadingproperty, which has been supported for a while and thus should not cause any problems.To prevent increasing the LCP, the first 20 images are eagerly loaded (approx. amount of images shown on a 1920x1080 display).