Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): whitespace in person name #5401

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix(web): whitespace in person name #5401

merged 2 commits into from
Nov 30, 2023

Conversation

martabal
Copy link
Member

Changes made in this PR

This PR adds the ability to search people with white spaces in their names.
Fixes #5397

jrasm91
jrasm91 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we share this code between the two pages?

@martabal
Copy link
Member Author

Can we share this code between the two pages?

Done

@alextran1502 alextran1502 merged commit b396e0e into main Nov 30, 2023
18 checks passed
@alextran1502 alextran1502 deleted the fix/whitespaces-in-person-name branch November 30, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Suggest people when typing a name doesn't handle full names
3 participants
@martabal @jrasm91 @alextran1502