Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): use zoomedpagetransition for galleryvieweroute #5495

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix(mobile): use zoomedpagetransition for galleryvieweroute #5495

merged 1 commit into from
Dec 5, 2023

Conversation

shenlong-tanwen
Copy link
Member

@shenlong-tanwen shenlong-tanwen commented Dec 5, 2023 •
edited
Loading

Changes made in the PR

  • Overrides the default transition for the GalleryViewerRoute to use the same transition animation in Android and iOS devices. This fixes the issue where opening a thumbnail in iOS shows a slideLeft transition for the page, while the hero animation is still in progress resulting in a weird animation

Screen capture

Before After
before-p.mp4
after-p.mp4

@alextran1502 alextran1502 merged commit d5f6584 into main Dec 5, 2023
18 checks passed
@alextran1502 alextran1502 deleted the fix/ios-gallery-viewer-animation branch December 5, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@fyfrey fyfrey Awaiting requested review from fyfrey

Assignees
No one assigned
Labels
📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shenlong-tanwen @alextran1502