fix: notify mobile app when live photos are linked #5504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in the PR:
A new event
on_asset_hiddenis added to notify the clients when an asset is hidden in the serverThe new end point is used to notify the clients when motion part of a live photo is hidden so that the clients in turn can handle them
The
on_asset_hiddenevent is handled in the mobile app by removing the asset from the local dbThe websocket pending changes code is also refactored. A new ID field is added to each pending change and processed changes are removed based on the ID instead of removing them based on the type which could result in cases where an event might be missed
The changes in
album_thumbnail_listtile.dartis not related to this PR, but all it does is to wrap the children in anExpandedwidget to prevent overflows in albums having large title