Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): mobile album sort not persisting #5584

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

shenlong-tanwen
Copy link
Member

Fixes #5579

Changes made in the PR

  • Uses storeIndex of AlbumSortMode to properly return the type of sort mode
  • Replaces mockito with mocktail
  • Unit tests for the following providers AlbumSortByOptions and AlbumSortOrder

@alextran1502 alextran1502 merged commit 8847ebe into main Dec 10, 2023
18 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-album-sort-save branch December 10, 2023 02:31
jonhnet pushed a commit to jonhnet/immich that referenced this pull request Dec 15, 2023
* chore(deps): use mocktail instead of mockito

* refactor: move stubs to fixtures/

* fix: fetch assetsortmode based on storeindex

* test: validate AlbumSortByOptions provider

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mobile: album sorting method is not saved
2 participants