refactor(server): auth dto #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
refactor/auth-dto
branch
from
d3bdb99
to
d6b0c5e
Compare
jrasm91
commented
Dec 10, 2023
Comment on lines
+6
to
12
| export class AuthDto { | ||
| user!: UserEntity; | ||
|
|
||
| apiKey?: APIKeyEntity; | ||
| sharedLink?: SharedLinkEntity; | ||
| userToken?: UserTokenEntity; | ||
| } |
There was a problem hiding this comment.
This is the bulk of the change, the rest of it is just renaming/updating accessors.
| @@ -93,12 +93,12 @@ export class AppGuard implements CanActivate { | |||
| const req = context.switchToHttp().getRequest<AuthRequest>(); | |||
|
|
|||
| const authDto = await this.authService.validate(req.headers, req.query as Record<string, string>); | |||
| if (authDto.isPublicUser && !isSharedRoute) { | |||
| if (authDto.sharedLink && !isSharedRoute) { | |||
There was a problem hiding this comment.
What is the alternative mechanism to determine if a user is a public user?
There was a problem hiding this comment.
auth via a shared link implies the user is a "public user".
alextran1502
approved these changes
Dec 10, 2023
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* refactor: AuthUserDto => AuthDto * refactor: reorganize auth-dto * refactor: AuthUser() => Auth()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure (simplify/standardize) the
AuthDto, which is used everywhere.