Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): re-add open graph tags for public share links #5635

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Dec 11, 2023

Serve a dynamic index.html page, which includes appropriate <meta> tags for the shared link route.

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I assume this has been tested in production build?

@alextran1502 alextran1502 changed the title feat: re-add open graph tags for public share links feat(web): re-add open graph tags for public share links Dec 11, 2023
@alextran1502 alextran1502 merged commit ed43587 into main Dec 11, 2023
18 checks passed
@alextran1502 alextran1502 deleted the feat/url-previews branch December 11, 2023 19:37
jonhnet pushed a commit to jonhnet/immich that referenced this pull request Dec 15, 2023
…5635)

* feat: re-add open graph tags for public share links

* fix: undefined in html

* chore: tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants