-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): grid on people page #5640
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK, but you can actually accomplish all of this with css using flex, not with javascript that has to run in the browser and may cause performance issues on slower devices, like phones.
The thumbnail width is re-calculated only when the width of the div containing all the thumbnails change. So could be an issue only on screen rotation |
b2ed8a7
to
b27b95a
Compare
Changed to use grid instead |
It's the video updated too or is that the old one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I just changed it |
Changes made in this PR
With this PR, the people grid always takes up the full available width and the size of the thumbnails changes depending on the screen size.
Screenshots
2023-12-11.21-23-06.mp4
2023-12-11.21-21-13.mp4