feat(web,server)!: runtime log level #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d154fdb
|
| Status: | ⚡️ Build in progress... |
bo0tzz
reviewed
Dec 13, 2023
There was a problem hiding this comment.
This is nice! I do think we should keep the option to configure log level early via an env var, I can imagine things breaking hard enough that you can't even make it into the UI to set the log level. A config file would work there, but is relatively quite a bit more work to set up and might interfere with other troubleshooting.
danieldietzler
approved these changes
Dec 13, 2023
|
How should I resolve the two? Should I just ignore the runtime value while the environment variable is set? |
jrasm91
force-pushed
the
feat/runtime-log-level
branch
from
c1f6412
to
a14bdb7
Compare
jrasm91
changed the title
bo0tzz
approved these changes
Dec 13, 2023
jrasm91
force-pushed
the
feat/runtime-log-level
branch
from
36e658f
to
d154fdb
Compare
martabal
approved these changes
Dec 14, 2023
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* feat: change log level at runtime * chore: open api * chore: prefer env over runtime * chore: remove default env value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Breaking Change
LOG_LEVELvalue ofsimplehas been removed.Use
loginstead (or remove the env entirely)Change the log level at runtime:
LOG_LEVELis set at the environment variable level.