-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): remove shared link with removed asset #5845
Conversation
Deploying with
|
Latest commit: |
cc3b9e8
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ec8a3944.immich.pages.dev |
Branch Preview URL: | https://fix-remove-shared-link.immich.pages.dev |
032a60c
to
cc3b9e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. Deleting an asset will delete all shared links that include it, even if other assets are still shared.
I can't experience this behavior, is it a background task or something ? 🤔 |
Did you test adding multiple assets to a single shared link and then deleting one asset? Fom what I understand the cascade should try to delete the shared link that still contains other assets. Is this what happens? |
Am I missing something ? 2023-12-19.16-45-26-2.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I misread the migration originally. This looks good.
fixes #5842