fix(web): open image in new tab with memories on firefox #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9c05576
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ee8091b.immich.pages.dev |
| Branch Preview URL: | https://fix-memory-image-firefox.immich.pages.dev |
|
Whhhhhhhhy do we need more z index changes.... |
|
You want to be able to click on the button when navigating your memories. I think we also use z indexes for navigation buttons on the asset-viewer. |
|
Then why can't we draw them on top? Z-index is for overwriting the default stacking order. Why does the default order not work? We should try to fix that if possible instead. |
jrasm91
approved these changes
Dec 19, 2023
|
Like you suggested, buttons come after the image to avoid using z-index |
martabal
added a commit
that referenced
this pull request
Jan 9, 2024
* fix: open image in new tab with memories on firefox * don't use z-index --------- Co-authored-by: Alex <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5751