Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): use proper id for gallery_viewer hero attribute #5894

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

shenlong-tanwen
Copy link
Member

@shenlong-tanwen shenlong-tanwen commented Dec 20, 2023

Fixes #5891

Changes made in the PR:

  • Uses the proper asset ID for the hero attributes so the hero animation is proper even when we exit from a stack children
hero.mp4

@shenlong-tanwen shenlong-tanwen changed the title fix(mobile): use proper id for gellery_viewer hero attribute fix(mobile): use proper id for gallery_viewer hero attribute Dec 20, 2023
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef287a2
Status: ✅  Deploy successful!
Preview URL: https://fa06e10a.immich.pages.dev
Branch Preview URL: https://fix-mobile-stack-hero-anim.immich.pages.dev

View logs

@alextran1502 alextran1502 merged commit 1542922 into main Dec 20, 2023
23 checks passed
@alextran1502 alextran1502 deleted the fix/mobile-stack-hero-anim branch December 20, 2023 17:23
@martabal
Copy link
Member

Wow you're fast

martabal pushed a commit that referenced this pull request Jan 9, 2024
Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Animation with stacked asset on mobile
3 participants