feat(server,ml): remove image tagging #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
from
f198694
to
c34c8b3
Compare
Deploying with
|
| Latest commit: |
401901d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5eae260f.immich.pages.dev |
| Branch Preview URL: | https://chore-ml-remove-image-taggin.immich.pages.dev |
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
from
c34c8b3
to
2abb94e
Compare
bo0tzz
approved these changes
Dec 20, 2023
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
3 times, most recently
from
b64a997
to
f58b224
Compare
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
from
f58b224
to
8cd8fe9
Compare
mertalev
changed the title
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
3 times, most recently
from
e560e81
to
6fdbd1a
Compare
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
from
6fdbd1a
to
979151f
Compare
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
from
3e3caaa
to
f12b393
Compare
mertalev
changed the title
mertalev
force-pushed
the
chore/ml-remove-image-tagging
branch
from
958f49f
to
401901d
Compare
|
Why did we change the behavior of incorrect values in the config file? Did we decide to make them warnings instead? |
|
It behaves the same for incorrect values, but now warns instead of throwing for extras. I think this is less disruptive; it doesn't need to error there as long as it lets the admin be aware that the option wasn't used. It's not like setting an unused env will throw either. |
|
Fair enough. |
martabal
pushed a commit
that referenced
this pull request
Jan 9, 2024
* remove image tagging * updated lock * fixed tests, improved logging * be nice * fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This job has been effectively deprecated for some time and is currently disabled by default. The removal of it will be good in several respects:
The image size has been shrunk from 1.66gb to 762mb.
The ML service's RAM usage at startup has decreased from 320mb to 215mb.
How Has This Been Tested?
Tested that the server boots up and that the ML endpoints still work.