Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev): move envs to image #5906

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore(dev): move envs to image #5906

merged 1 commit into from
Dec 21, 2023

Conversation

mertalev
Copy link
Contributor

Description

There are a few envs that don't really need to be configured, so this PR moves them to the docker images.

  • NVIDIA_DRIVER_CAPABILITIES=all
  • NVIDIA_VISIBLE_DEVICES=all
    • These envs are used for nvenc, but they're benign if set anyway so setting it beforehand makes setup easier.
    • Inspired by Jellyfin as they're set in their official image as well.
  • NODE_ENV=development
    • The dev server uses the dev stage of the image, so no need to set this in the docker-compose instead of the image
    • The prod stage already sets NODE_ENV=production
    • Removed from immich-machine-learning as it's completely unused there

@mertalev mertalev added the deployment Deployment related tasks label Dec 21, 2023
@alextran1502 alextran1502 merged commit f602295 into main Dec 21, 2023
20 of 21 checks passed
@alextran1502 alextran1502 deleted the chore/server-move-nvidia-env branch December 21, 2023 15:28
mertalev added a commit that referenced this pull request Dec 21, 2023
@mertalev
chore(dev): move envs to image (#5906)
1854e69
mertalev added a commit that referenced this pull request Dec 21, 2023
@mertalev
chore(dev): move envs to image (#5906)
ca214d6
@mertalev mertalev mentioned this pull request Dec 22, 2023
Closed
mertalev added a commit that referenced this pull request Dec 22, 2023
@mertalev
chore(dev): move envs to image (#5906)
93e4be0
martabal pushed a commit that referenced this pull request Jan 9, 2024
@mertalev @martabal
chore(dev): move envs to image (#5906)
4eb4ef6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
deployment Deployment related tasks 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mertalev @jrasm91 @alextran1502