Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): cannot open detail panel in public shared link #5946

Merged
merged 3 commits into from
Dec 23, 2023
Merged

Conversation

alextran1502
Copy link
Contributor

fixes #5943

Copy link

cloudflare-pages bot commented Dec 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd42c27
Status: ✅  Deploy successful!
Preview URL: https://08fbcc30.immich.pages.dev
Branch Preview URL: https://fix-5943.immich.pages.dev

View logs

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@martabal martabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@alextran1502 alextran1502 merged commit aaa7a61 into main Dec 23, 2023
20 checks passed
@alextran1502 alextran1502 deleted the fix-5943 branch December 23, 2023 16:07
@kk7ds
Copy link

kk7ds commented Dec 26, 2023

This is a pretty big breakage -- might we see a point release to include this? I just started deploying immich and public url-based shares is pretty much the primary reason I want to use it, so this is a show stopper for me :)

Thanks!

@danieldietzler
Copy link
Member

danieldietzler commented Dec 26, 2023

@kk7ds I don't think we're going to have another release this year unfortunately. (many of us are on vacation or try to work less on immich and new releases (even dot releases) always introduce more support tickets) However, we have quite a lot of new stuff again so it's quite likely there will be a new release (1.92) sometime next week (don't quote me on this! that's just my impression). Sorry but I hope you can understand this :)

@kk7ds
Copy link

kk7ds commented Dec 26, 2023

Ack, I didn't know what the release schedule looks like, but it seemed like the point releases for 1.91 were coming with just a few fixes each and this one is (selfishly of course) important to me. But cool, I'll hope for next week.

@danieldietzler
Copy link
Member

danieldietzler commented Dec 26, 2023

Yeah because we always try to hold off PRs after a new release to be able to get some fixing PRs done in the first couple of days. But since 1.91.4 we've had bigger PRs like #5832 which (while also being a fix) may introduce new issues (that would result in many new tickets).

(I may still raise the idea internally, overall there aren't too crazy PRs atm)

@danieldietzler
Copy link
Member

@kk7ds There may be another release by tomorrow but no promises ;)

martabal pushed a commit that referenced this pull request Jan 9, 2024
* fix(web): cannot open detail panel in public shared link

* fix websocket auth message

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Link shared public albums have issues displaying and working on the web
4 participants