-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): cannot open detail panel in public shared link #5946
Conversation
Deploying with
|
Latest commit: |
bd42c27
|
Status: | ✅ Deploy successful! |
Preview URL: | https://08fbcc30.immich.pages.dev |
Branch Preview URL: | https://fix-5943.immich.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
This is a pretty big breakage -- might we see a point release to include this? I just started deploying immich and public url-based shares is pretty much the primary reason I want to use it, so this is a show stopper for me :) Thanks! |
@kk7ds I don't think we're going to have another release this year unfortunately. (many of us are on vacation or try to work less on immich and new releases (even dot releases) always introduce more support tickets) However, we have quite a lot of new stuff again so it's quite likely there will be a new release (1.92) sometime next week (don't quote me on this! that's just my impression). Sorry but I hope you can understand this :) |
Ack, I didn't know what the release schedule looks like, but it seemed like the point releases for 1.91 were coming with just a few fixes each and this one is (selfishly of course) important to me. But cool, I'll hope for next week. |
Yeah because we always try to hold off PRs after a new release to be able to get some fixing PRs done in the first couple of days. But since 1.91.4 we've had bigger PRs like #5832 which (while also being a fix) may introduce new issues (that would result in many new tickets). (I may still raise the idea internally, overall there aren't too crazy PRs atm) |
@kk7ds There may be another release by tomorrow but no promises ;) |
* fix(web): cannot open detail panel in public shared link * fix websocket auth message * refactor
fixes #5943