chore(server): refactor locks #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b94b59e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://03445fae.immich.pages.dev |
| Branch Preview URL: | https://chore-refactor-locks.immich.pages.dev |
jrasm91
reviewed
Dec 23, 2023
jrasm91
approved these changes
Dec 26, 2023
martabal
pushed a commit
that referenced
this pull request
Jan 9, 2024
* lock refactor * add mocks * add await * move database repo injection to service * update tests * add mock implementation * remove unused imports * this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves locking functionality to the new database repository. Specifically, it adds three methods and replaces existing lock usages with them:
withLocktakes a lock type and an async callback and acquires an async lock as well as a Postgres advisory lock. It wraps the callback in a try / finally clause that ensures the advisory lock is released.isBusyis a synchronous check to see if a lock is being used without actually acquiring itwaitasynchronously waits for the lock to be released by acquiring and immediately releasing itwithLockfor this purpose as it only relies on the async lock, not a Postgres advisory lockHow Has This Been Tested?
The server booted, running a Smart Search job worked, and changing the CLIP model while jobs were running had the same behavior (i.e. the active jobs waited for the update to complete, then errored because they had different size embeddings, while later jobs completed successfully).