-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit and update of FAQ+new database GUI guide #5958
Conversation
You should be able to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, content-wise it's already really good and very helpful!
Sorry if seeing 38 review comments is a little slaying. It ended up being a lot of little nitpicks but I think that's what you wanted, especially given that you used a translator for it.
I've sometimes skipped sections that felt WIP.
Generally, you should pay attention to capitalization and missing periods (there are just multiple sentences without a '.')
I hope this is somewhat helpful though! :) Really appreciate your hard work on this (so far)!
Wow, that's great! I will work on the fixes soon! Thanks for the corrections and your time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! My feedback is generally about making the FAQ as useful as possible for the average user. When in doubt, keep it simple. Also, don't link to spreadsheets, Discord or Reddit. The information in the FAQ should stand on its own and be presented in an accessible way.
I will soon make all the necessary corrections. Under Assets -> How to delete transcoded assets if I don't need them anymore? Under Assets -> What happens when 2 users have access to load from the same library? Under Assets -> Is it possible to use item compression like in App-Which-Must-Not-Be-Named.? Under performance -> I disabled machine learning but I still experience high CPU usage why? Under ML -> Does Immich have animals recognition? Under Mobile application -> I can't log into the application after the server update, what can I do? |
|
Great, I'll start working on everything soon, |
This would be a good addition, but only after we actually implement #5873
This is good, but reword to "What happens if an asset exists in more than one account?".
Eh sure, but just say it isn't supported.
I think this is redundant if we have a "Why is Immich using so much of my server's CPU?" question that explains which jobs are CPU-intensive.
This is good.
This is also good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, some more minor things. Also, it there are a few open issues still from my last review :)
|
||
Immich uses CLIP models, for more information about CLIP and its capabilities can be [read here](https://openai.com/research/clip). | ||
|
||
### How does facial recognition work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the question you're actually answering is "Which models are being used?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually my suggestion. I was thinking we could flesh it out some more and have that be the question. Do you think it'd be better for them to be separate questions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically don't know anything about machine learning stuff and reading the respective text did not explain to me how facial recognition works. I don't think I have a preference on either making it two questions or extending the current text. All I'm saying is that the question right now isn't being answered by the text :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I can try to expand on this, but if we're going to expand on it, maybe you should put it in one of these:
https://immich.app/docs/features/facial-recognition/
or here
https://immich.app/docs/administration/jobs
or
https://immich.app/docs/developer/architecture
In any case, I think that an extended explanation would definitely be something welcome, it would allow contributors to the code or people to understand how the models work in Immich. I understand that it may not be of interest to everyone, but people can be directed to read a research article if they are interested in the depth of things
Here is my suggestion:
Immich uses InsightFace to perform
face detection and recognition.
Every time a new property is uploaded to Immich, thumbnails are created for it.
InsightFace uses machine learning to identify faces in thumbnails, for each face a unique identifier is created, also called an embed, and it belongs to the Postgers database under the face_asset column where the embed values of all the faces in the image + the position of the face in the image are saved, this is saved as a vector value, Immich performs a comparison of :
The embed created for the face from thumbnails of the uploaded asset
Compared to the embeds that exist in a database
Before the additional association there are 2 values that Immich is set to check according to:
-
If a value greater than the MIN DETECTION SCORE defined by the user is received, then Immich will not consider it as a face to add
-
If a value equal to or higher than the MAX RECOGNITION DISTANCE defined by the user is received, then Immich will insert the embed found in the database into the embed of an existing person (if any) if there is no existing person, Immich will create a new person.
For each new embed, Immich performs a test of the 100 closest embeds to the new embed, so that there is no unnecessary load on the system for searching among all the embeds in the database.
@mertalev What do you think of this explanation?
I hope the translation was able to keep my explanation clear enough.
Do you think this could be an essential addition? How and where are assets stored in Immich?1. User-Specific Folders:
2. Asset Types and Storage Locations:
:::danger How can I hide photos from the timeline?You can archive them. What happens if I changed or canceled vdeo transcoding ?If you chose to cancel the vdeo transcoding, the transcoded videos will be deleted, if you chose to change the encoding format, the newly encoded videos will overwrite the old ones. under Machine Learning The immich_model-cache volume takes up a lot of space, what could be the problem?If you installed several models and chose not to use some of them, it might be worth deleting the old models that are in immich_model-cache. |
The first question is out of scope for a FAQ, but the others are good. The transcoding answer is wrong though because it won't delete on cancel. |
Thank you for your review!
|
|
That means a user can't decide to delete the conversions if he wants to right now? If so, the answer to this question will be that as long as the asset is not deleted through the browser interface, the transcode created will continue to exist. Right? |
No, that's not right. A user can delete a given existing transcode if they set a transcode policy that makes it unnecessary and then run a transcoding job for it. This can be done on a per-asset basis by starting a transcoding job for an asset, or for all assets by running transcoding jobs for all assets. |
Good to know, I'll add that as answer:
By the way In your opinion it would be necessary to specify at libraries |
agree. In your opinion under Comparison.md it would be necessary to add ::: Tip Is it also worth adding information about the feature that Immich has keyboard shortcuts? If so, where? |
I think it would be better if all the FAQs where on a single page. We can still group them into sections (on a single page) and make them collapsible, which I think makes the content more accessible rather than having to page through 10 different pages. Also, existing FAQ links would all be broken. |
If you move everything back into a single page, I'm happy to help look into some react component or format that would make it more usable. |
I was thinking about putting it all on the same page as it was before I started working on it, like I mentioned in the first message of this PR.
|
I think it would be better if they were all in the same page. |
If we may want to add a TOC for other things I could look into this but I agree with Jason in that the FAQ should be just one page - with maybe an "accordion" component or something, so that single sections can collapse. |
I managed to create a code that will do the job so that the previous comment is not relevant, now it is generated automatically. But if it's not part of what works for Immich I'll change it all to one page. |
I don't think we only want a table of contents. We want the actual content all together in one place, on the same page. |
Got it, I'll upload a one page version for everything soon. Sorry for all the commit alerts...I'm pretty new to this |
…n information" This reverts commit da63439.
@jrasm91 I moved everything to the configuration of AIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! The additional information is great and we can iterate on this page over time to continue to fine tune and improve it.
I think this actually looks really good on a single page. You can easily search for everything and content is very discoverable (plus, all the old links still work 🎉).
Thanks for the merge :) Regarding the GUI guide of the database, I saw that you removed the EXTRA part, it is mainly for Ubuntu users, there is no GUI as software, it is a GUI through the browser, so I added information for those who want to find out where the link to connect to the database via PgAdmin is |
Are you talking about those running a headless server? |
I mean those running Immich on a Linux system like Ubuntu, where there is no GUI for the pgAdmin software and you have to use a browser for a user interface. This is explained in the manual in the EXTRA section. In addition, I added up-to-date information regarding backup in a Windows-based system and information about the new storage format on new and old machines. |
I'm not sure I understand. I use pgAdmin and I'm on ubuntu and it works fine. |
Maybe it was just me... |
Added edit and update of FAQ:
Instructors:
Added database login guide using PgAdmin (GUI).
Note:
My English is not 100% and I use a translation, maybe you should follow grammar and words that probably weren't translated properly, I did my best so that there are no situations where there is a spelling mistake
Note 2:
i want to use docusaurus with
import TOCInline from '@theme/TOCInline';
https://docusaurus.io/docs/markdown-features/toc#inline-table-of-contents
So that I can display all the TOC from all MD pages in FAQ.mdx
For a quick search for a question among all FAQ departments
Do you think there is a way I can make this happen?
It's not finished yet, but I'd like you to take a look at it