Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): search across own+partner assets #5966

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Dec 25, 2023

search now works across own and partner assets (only for partners visible in the combined timeline). Thus, user experience is improved (seeing partner assets -> searching partner assets; not seeing partner assets -> searching only own assets).

Copy link

cloudflare-pages bot commented Dec 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e9759b0
Status: ✅  Deploy successful!
Preview URL: https://fb6c7414.immich.pages.dev
Branch Preview URL: https://dev-search-across-partners.immich.pages.dev

View logs

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@jrasm91 jrasm91 merged commit cc7ba3c into main Jan 1, 2024
21 checks passed
@jrasm91 jrasm91 deleted the dev/search-across-partners branch January 1, 2024 22:25
martabal pushed a commit that referenced this pull request Jan 9, 2024
* feat(server): search across own+partner assets

* generate sql

* fix sql parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants