Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: hardware-transcoding.md #5968

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Conversation

DCCInterstellar
Copy link
Contributor

@DCCInterstellar DCCInterstellar commented Dec 25, 2023

I accidentally closed #5924 last night. Copied the same code that I made yesterday to this one.

I accidentally closed immich-app#5924 for some odd reason. Copied the same code changes to this one.
@mertalev mertalev added the documentation Improvements or additions to documentation label Dec 25, 2023
@mertalev
Copy link
Contributor

I am unsure of how to run npm run format:fix in Github. I'm brand new on how to do this. Sorry!

No worries! You run this command locally. In the docs folder, run npm i and then npm run format:fix. Then commit and push the formatting changes.

@DCCInterstellar
Copy link
Contributor Author

I am unsure of how to run npm run format:fix in Github. I'm brand new on how to do this. Sorry!

No worries! You run this command locally. In the docs folder, run npm i and then npm run format:fix. Then commit and push the formatting changes.

I apologize. I'm still confused about how to run the command locally. Do I need to download the GitHub repo locally then run the command? OR Can I just do it from the Github Repo?

Screenshot 2023-12-26 at 3 48 28 PM

@mertalev
Copy link
Contributor

Ahh, you're making changes from the website.

So if you don't have git installed, you'll need to install it first and do the initial setup. You also need to install npm if you don't have it. You can get it by installing Node.js.

Then you can clone your repo locally with git clone https://github.com/DCCInterstellar/immich.git, switch to your branch with git checkout patch-1 and run the commands I mentioned earlier. Once things are formatted, run git add . to stage all the changes, commit them with git commit -m "updated formatting" and push them to the branch with git push.

@DCCInterstellar
Copy link
Contributor Author

Ahh, you're making changes from the website.

So if you don't have git installed, you'll need to install it first and do the initial setup. You also need to install npm if you don't have it. You can get it by installing Node.js.

Then you can clone your repo locally with git clone https://github.com/DCCInterstellar/immich.git, switch to your branch with git checkout patch-1 and run the commands I mentioned earlier. Once things are formatted, run git add . to stage all the changes, commit them with git commit -m "updated formatting" and push them to the branch with git push.

Perfect! Thank you so much for that information! First time doing a push and pull via CML! I just updated the formatting!

Added line 66 saying that `NVIDIA_DRIVER_CAMPABILITITES` is no longer required.
@jrasm91 jrasm91 changed the title Update hardware-transcoding.md docs: hardware-transcoding.md Jan 1, 2024
@jrasm91 jrasm91 enabled auto-merge (squash) January 1, 2024 20:34
@jrasm91 jrasm91 merged commit 2688e05 into immich-app:main Jan 1, 2024
19 checks passed
martabal pushed a commit that referenced this pull request Jan 9, 2024
* Update hardware-transcoding.md

I accidentally closed #5924 for some odd reason. Copied the same code changes to this one.

* updated formatting

* Update hardware-transcoding.md

Added line 66 saying that `NVIDIA_DRIVER_CAMPABILITITES` is no longer required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants