(mobile): ios - calculate hash using CryptoKit #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlong-tanwen
changed the title
Deploying with
|
| Latest commit: |
7900be6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3dacb896.immich.pages.dev |
| Branch Preview URL: | https://refactor-ios-native-hash.immich.pages.dev |
|
Are there any measurements you can show? Ideally you could output the timings for pre/post new implementation and make sure it's actually working how it should be. |
Benchmark result
Using Swift
{
"hash":[50,41,89,254,196,122,144,222,211,137,116,224,231,77,167,126,45,187,43,70],
"id":"8F85B2B4-DC66-4E2C-AD75-6CF732887BE3/L0/001",
"isarId":-9220662956256676000
}
Using Dart
{
"hash":[50,41,89,254,196,122,144,222,211,137,116,224,231,77,167,126,45,187,43,70],
"id":"8F85B2B4-DC66-4E2C-AD75-6CF732887BE3/L0/001",
"isarId":-9220662956256676000
}
|
alextran1502
approved these changes
Jan 5, 2024
martabal
pushed a commit
that referenced
this pull request
Jan 9, 2024
* ios: calculate hash using CryptoKit * chore: remove unused crypto dep --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com> Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in the PR
CryptoKitto calculate SHA-1 hashes in iOS instead of the dart implementation for better performance