Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): multiselect for search & person page #6016

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Dec 27, 2023

this PR enables multiselect on search result, person asset result and videos page.

It allows users to add assets from search to albums etc.

Copy link

cloudflare-pages bot commented Dec 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0975b7f
Status: ✅  Deploy successful!
Preview URL: https://e814ec95.immich.pages.dev
Branch Preview URL: https://dev-multiselect-video-person.immich.pages.dev

View logs

editEnabled: true,
favoriteEnabled: true,
stackEnabled: false,
onRefresh: refresh,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Using the refresh in MultiSelectGrid to actually refresh the search

Copy link
Member

@shenlong-tanwen shenlong-tanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 enabled auto-merge (squash) January 5, 2024 21:16
@alextran1502 alextran1502 merged commit 56cde04 into main Jan 5, 2024
20 checks passed
@alextran1502 alextran1502 deleted the dev/multiselect-video-person-search branch January 5, 2024 21:23
martabal pushed a commit that referenced this pull request Jan 9, 2024
* feat(mobile): multiselect for search & person page

* merge main

---------

Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants