feat(mobile): Focus search on doubletap nav button #6048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bo0tzz Would you be so kind to apply the mobile tag for me ? |
This was referenced Jan 5, 2024
shenlong-tanwen
approved these changes
Jan 14, 2024
mobile/lib/modules/search/providers/search_focus_notifier.provider.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: shenlong <139912620+shenlong-tanwen@users.noreply.github.com>
And fix naming to better represent type.
justinvdk
force-pushed
the
dev/search-nav-tap-focus
branch
2 times, most recently
from
03cb7c7
to
16e50a0
Compare
alextran1502
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #6040
Focuses search when tapping on the 'search' navigational button when search page already active.
Small demo:
output.mp4
This was my first change in a Flutter codebase. The way I declare a closure to capture the
WidgetRefinsideImmichSearchBarfeels a bit dirty. Would love to hear what would be a better approach.Tested on "tablet size"-screens by hardcoding the conditional to use that layout.