-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): onboarding #6066
feat(web): onboarding #6066
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
The storage template step currently has both a save button (from the template settings panel) and a done button (from the onboarding flow). I think it would be better if there is only one button that both saves the settings and completes/continues the onboarding.
server/src/infra/migrations/1703950964498-DefaultOnboardingForExistingInstallations.ts
Outdated
Show resolved
Hide resolved
web/src/lib/components/onboarding-page/onboading-storage-template.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Imo the theme buttons can be a little smaller. They're currently huuuuge
web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/onboarding-page/onboading-storage-template.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the server changes seem to be adding the showOnboarding property to the user's table. I think it might make more sense for this to be a setting per instance instead of per user.
One option would be to just revert all the server-side changes, and then add isOnboarded
next to isInitialized
in the ServerConfigDto
, which is returned from /api/server-info/config
. When true, show the onboarding screen. Save this setting in the database via the ISystemMetadataRepository
.
Co-authored-by: bo0tzz <git@bo0tzz.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (besides the fact there are no tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(web): onboarding * feat: openapi * feat: modulization * feat: page advancing * Animation * Add storage templaete settings * sql * more style * Theme * information and styling * hide/show table * Styling * Update user property * fix test * fix test: * fix e2e * test * Update web/src/lib/components/onboarding-page/onboarding-hello.svelte Co-authored-by: bo0tzz <git@bo0tzz.me> * naming * use System Metadata * better return type * onboarding using server metadata * revert previous changes in user entity * sql * test web * fix test server * server/web test * more test * consolidate color theme change logic * consolidate save button to storage template * merge main * fix web --------- Co-authored-by: bo0tzz <git@bo0tzz.me>
This PR adds onboarding steps for new instance to configure
onboarding.mp4