Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): update broken link #6094

Merged
merged 3 commits into from
Jan 1, 2024
Merged

fix(docs): update broken link #6094

merged 3 commits into from
Jan 1, 2024

Conversation

m1yon
Copy link
Contributor

@m1yon m1yon commented Jan 1, 2024

I noticed a broken link towards the bottom of the Config File page in the docs.

danieldietzler
danieldietzler approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, thanks! I actually stumbled across that earlier but didn't come around to fix it yet. Could you use just a path though? /docs/install/environment-variables should work

@m1yon
Copy link
Contributor Author

m1yon commented Jan 1, 2024

Oh nice, thanks! I actually stumbled across that earlier but didn't come around to fix it yet. Could you use just a path though? /docs/install/environment-variables should work

Whoops, updated!

@jrasm91
Copy link
Contributor

jrasm91 commented Jan 1, 2024

Do you mind changing the link in remote-access.md as well do use an internal url instead of an external one? (/docs/administration/reverse-proxy)

@jrasm91 jrasm91 added the documentation Improvements or additions to documentation label Jan 1, 2024
@jrasm91 jrasm91 enabled auto-merge (squash) January 1, 2024 20:26
@jrasm91 jrasm91 merged commit 523e7d4 into immich-app:main Jan 1, 2024
19 of 20 checks passed
@m1yon m1yon deleted the fix/env-variables-link branch January 1, 2024 23:02
martabal pushed a commit that referenced this pull request Jan 9, 2024
@m1yon @jrasm91 @martabal
fix(docs): update broken links (#6094)
579ce71 
* fix(docs): update broken link

* fix(docs): change to path

* fix(docs): second broken link

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m1yon @jrasm91 @danieldietzler