Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: svelte-kit-2 #6103

Merged
merged 3 commits into from
Jan 20, 2024
Merged

chore: svelte-kit-2 #6103

merged 3 commits into from
Jan 20, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jan 1, 2024

Upgrade to svelte kit 2 and vite 5.

  • Redirects no longer need to be thrown
  • Type imports are a lot more strict

Copy link

cloudflare-pages bot commented Jan 1, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c959b16
Status: ✅  Deploy successful!
Preview URL: https://bb43cedd.immich.pages.dev
Branch Preview URL: https://deps-svelte-kit-2.immich.pages.dev

View logs

@jrasm91 jrasm91 marked this pull request as ready for review January 18, 2024 04:53
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we have a linting rule that enforces type imports if we only use the import as a type and not as a value?

@alextran1502 alextran1502 merged commit 6e066aa into main Jan 20, 2024
21 checks passed
@alextran1502 alextran1502 deleted the deps/svelte-kit-2 branch January 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants