-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web,server): external domain setting #6146
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
...src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte
Show resolved
Hide resolved
Maybe a small thing to add. The external URl must be entered without a / at the end, otherwise the links conatining a // an wont work. Otherwise a really great addon! :-) |
Thanks for pointing this out! Actually, we shouldn't restrict the input but instead better sanitize the link :) |
* feat: external domain setting * chore: open api * mobile: handle serverconfig-externalDomain --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Hello Guys, I was tryng to expose externally only the "/share" links and not the entire immich service, just to share only photos. Someone can help me? Thank you! |
@devtechk Please open a new discussion or ask this question in our Discord, not in an already merged PR. However, as a first hint; that's something your reverse proxy should take care of (accept requests to /share if coming from a subnet/port/whatever). |
Thank you @danieldietzler I've just managed it. I used Nginx Proxy Manager and duckdns so I've allowed the /share/* location and denied the others location "/".I think I will open a new discussion to tell how I've done. Where I can find discord about immich? thank you |
The discord is linked right at the top of the readme. Glad to hear it works @devtechk :) |
Closes #6147.
Add the option to set the instance's "external domain", which currently is used as an override for
window.origin
when constructing the shared link url to copy to the clipboard.Admin Settings
Shared Links