feat(wip): add Combobox component for timezone picker #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking amazing! |
|
@m1yon I refactored the combo box so that it can be used in different components in the future, as well as cleaned up the change date component |
jrasm91
force-pushed
the
feat/improved-date-changer
branch
from
94ac85f
to
0be6e88
Compare
jrasm91
approved these changes
Jan 27, 2024
3 tasks
|
@alextran1502 @jrasm91 Thanks for picking this up and finishing it! I'm in the middle of a move so I haven't had a chance to work on it :/ Looks great though! |
|
No worries, hope the move goes well 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new Combobox component, a custom select with autocomplete functionality.
The purpose of this component is to replace the current timezone dropdown and be used wherever we need it in the future:
Current:
New (WIP):
