refactor(web): admin settings #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4f4ade3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b64fa118.immich.pages.dev |
| Branch Preview URL: | https://refactor-admin-settings.immich.pages.dev |
danieldietzler
force-pushed
the
refactor/admin-settings
branch
4 times, most recently
from
c132e52
to
1b876d1
Compare
|
Is this PR ready for review? |
I think so, yeah. Probably not "mergeable" yet because I may want to add some small things, not sure yet. It needs to be extensively tested though, that's for sure! Much of the logic/structure has changed :) |
danieldietzler
force-pushed
the
refactor/admin-settings
branch
from
be10c80
to
9438fe8
Compare
jrasm91
approved these changes
Jan 12, 2024
web/src/lib/components/admin-page/settings/admin-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/admin-settings.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/admin-page/settings/admin-settings.svelte
Outdated
Show resolved
Hide resolved
|
Found a few issues, but they have all been fixed now. I was able to setup, reset, reset to default, save, reload the page, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/x of refactoring web stuff