feat(web): previous button for on-boarding steps #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
14ca424
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3f8eb6f.immich.pages.dev |
| Branch Preview URL: | https://feat-previous-onboarding.immich.pages.dev |
martabal
changed the title
martabal
force-pushed
the
feat/previous-onboarding
branch
from
8da4025
to
c64e649
Compare
jrasm91
approved these changes
Jan 5, 2024
martabal
force-pushed
the
feat/previous-onboarding
branch
from
9a653a9
to
79121aa
Compare
jrasm91
approved these changes
Jan 5, 2024
Comment on lines
47
to
62
| <section id="onboarding-page" class="min-w-screen flex min-h-screen p-4"> | ||
| <div class="flex flex-col w-full"> | ||
| <div class="w-full bg-gray-300 dark:bg-gray-600 rounded-full h-2.5"> | ||
| <div | ||
| class="progress-bar bg-immich-dark-primary/80 dark:bg-immich-primary h-2.5 rounded-full transition-all duration-200 ease-out" | ||
| style="width: {(index / (onboardingSteps.length - 1)) * 100}%" | ||
| ></div> | ||
| </div> | ||
| <div class="w-full min-w-screen py-8 flex h-full place-content-center place-items-center"> | ||
| <svelte:component | ||
| this={onboardingSteps[index].component} | ||
| on:done={handleDoneClicked} | ||
| on:previous={handlePrevious} | ||
| /> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
this looks like a great candidate for its own component.
<Stepper on:previous={} on:next={} bind:selected>
<Page1 />
<Page2 />
<Page3 />
</Stepper>
|
Thank you for the PR, looks good. I change a few styling and remove the back button for the theme setting since there is no need to go back to the welcome card. |
alextran1502
approved these changes
Jan 6, 2024
martabal
added a commit
that referenced
this pull request
Jan 9, 2024
* feat: previous on the onboarding * fix: storage full screen * feat: transition * use svelte files for svg * fix: use icon component * fix: additional check * styling' --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
This PR adds the ability to go back to the previous on-boarding step with a button. It adds a progress bar too.
Screenshots
2024-01-05.00-02-23.mp4